Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey test QueuedThreadPoolTest.testThreadPool #9622

Closed
lorban opened this issue Apr 4, 2023 · 1 comment · Fixed by #9623
Closed

Flakey test QueuedThreadPoolTest.testThreadPool #9622

lorban opened this issue Apr 4, 2023 · 1 comment · Fixed by #9623
Assignees
@lorban
Labels
flaky-test

Comments

@lorban
Copy link
Contributor

lorban commented Apr 4, 2023 •
edited

Jetty version(s)
10.0.x, 11.0.x, 12.0.x

Description
QueuedThreadPoolTest.testThreadPool started failing with

Expected: is <0>
     but: was <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.eclipse.jetty.util@11.0.15-SNAPSHOT/org.eclipse.jetty.util.thread.QueuedThreadPoolTest.waitForIdle(QueuedThreadPoolTest.java:714)
	at org.eclipse.jetty.util@11.0.15-SNAPSHOT/org.eclipse.jetty.util.thread.QueuedThreadPoolTest.testThreadPool(QueuedThreadPoolTest.java:305)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
@lorban lorban added Bug For general bugs on Jetty side Test labels Apr 4, 2023
@lorban lorban self-assigned this Apr 4, 2023
@lorban lorban mentioned this issue Apr 4, 2023
Closed
lorban added a commit that referenced this issue Apr 4, 2023
@lorban
#9622 replace wait loops with awaitility & add log on condition timeout
8f33389 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban closed this as completed Apr 4, 2023
@lorban lorban reopened this Apr 4, 2023
@lorban lorban added flaky-test and removed Bug For general bugs on Jetty side Test labels Apr 4, 2023
@lorban lorban mentioned this issue Apr 4, 2023
Merged
lorban added a commit that referenced this issue Apr 5, 2023
@lorban
#9622 replace wait loops with awaitility and ensure the tested value…
d0bfae1 
…s are stable for a certain duration

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 5, 2023
@lorban
#9622 replace wait loops with awaitility and ensure the tested value…
9ff24ea 
…s are stable for a certain duration

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
Copy link
Contributor Author

lorban commented Apr 5, 2023

Fixed in 10, merged to 11 and 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakey test QueuedThreadPoolTest.testThreadPool jetty/jetty.project
1 participant
@lorban