Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved HttpClient TLS documentation about server host name verifica… #9494

Merged
merged 1 commit into from Mar 14, 2023
Merged

Improved HttpClient TLS documentation about server host name verifica… #9494

merged 1 commit into from Mar 14, 2023

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Mar 13, 2023

…tion.

@sbordet
Improved HttpClient TLS documentation about server host name verifica…
8348ad0 
…tion.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from joakime March 13, 2023 16:28
boekhold
boekhold approved these changes Mar 14, 2023
View reviewed changes
Copy link

@boekhold boekhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation update makes it crystal-clear what the effect is of disabling the Endpoint Identification Algorithm. The update removes the previous ambiguity on whether certificate expiration date and CA certificate checking are affected as well.

@sbordet sbordet merged commit e6de810 into jetty-10.0.x Mar 14, 2023
@sbordet sbordet deleted the fix/jetty-10-clarify-client-tls-docs branch March 14, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boekhold boekhold boekhold approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbordet @boekhold