URI Host Mismatch with optional Compliance modes #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Checks if provided Host authority matches an absolute target-uri authority + Default is to reject with 400 Bad Request + Optional HttpCompliance to disable this check. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ use example.org (instead of example.net) + fix tests that are now failing due to enforcement of absolute target-uri authority and provided Host header Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…0.x/uri-host-mismatch
This PR fixes the miss-matched host header issue in the Request.setMetaData method. This requires no change to the HttpParser. A more comprehensive fix can be considered for jetty-12. Signed-off-by: gregw <gregw@webtide.com>
|
Actually 12 already has this well supported in HttpConnection, other than no compliance mode to allow for a miss-match. |
sbordet
requested changes
Feb 13, 2023
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
Updates from review Signed-off-by: gregw <gregw@webtide.com>
sbordet
approved these changes
Feb 13, 2023
joakime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative PR for #9312. This avoids changing the HttpParser and instead checks for a mismatched host only in the
Request.setMetaDatamethod.