Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Cookie Cutter #9339

Merged
merged 13 commits into from Feb 14, 2023
Merged

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Feb 9, 2023

No description provided.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Trying to get a good code coverage.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from gregw February 9, 2023 20:38
@sbordet sbordet marked this pull request as draft February 9, 2023 20:38
sbordet and others added 5 commits February 9, 2023 22:06
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
ignorable whitespace

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Select between CookieCutter and RFC6265CookieParser in factory method.

Signed-off-by: gregw <gregw@webtide.com>
Select between CookieCutter and RFC6265CookieParser in factory method.

Signed-off-by: gregw <gregw@webtide.com>
Select between CookieCutter and RFC6265CookieParser in factory method.
Improved legacy modes

Signed-off-by: gregw <gregw@webtide.com>
@gregw gregw requested a review from lorban February 12, 2023 05:13
javadoc

Signed-off-by: gregw <gregw@webtide.com>
@gregw gregw marked this pull request as ready for review February 12, 2023 21:51
Improve violation naming and javadoc

Signed-off-by: gregw <gregw@webtide.com>
Updates and renames from review

Signed-off-by: gregw <gregw@webtide.com>
@gregw
Copy link
Contributor

gregw commented Feb 13, 2023

@sbordet @lorban updated as per our hangout. @sbordet you can't review as it is your PR originally.... but comment and I'll get the idea.

gregw and others added 3 commits February 14, 2023 10:06
Support new compliance violations in old CookieCutter parser

Signed-off-by: gregw <gregw@webtide.com>
Exclude deprecated violations from non LEGACY modes.

Signed-off-by: gregw <gregw@webtide.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Copy link
Contributor Author

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gregw gregw merged commit 7b8c2c1 into jetty-10.0.x Feb 14, 2023
@gregw gregw deleted the fix/jetty-10-9334-review-cookie-cutter branch February 14, 2023 21:38
@gregw gregw linked an issue Feb 15, 2023 that may be closed by this pull request
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Feb 15, 2023
…old-docs-remove-logging-sections

* origin/jetty-12.0.x:
  Fixed FormAuthenticator redirection
  Happy no year
  Restore range test for ee10 DefaultServletTest.
  Restore non cross-context async session tests
  Jetty 12 - Restore ee10 tests (jetty#9214)
  fixed commented out test in CookieCutterTest
  Fix/jetty 10 9334 review cookie cutter (jetty#9339)
  remove section on remote debugging, as the information has already been incorporated into the operations and programming guides
  remove sections on debugging with IntelliJ and Eclipse
  remove Ant Jetty plugin section from the ToC
  Remove docs for the ant plugin
  Update SECURITY.md (jetty#9333)
@joakime joakime changed the title Fix/jetty 10 9334 review cookie cutter Review Cookie Cutter Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for Cookie RFC 2965 compliance
2 participants