Added SizeLimitHandler #8774
Merged
Added SizeLimitHandler #8774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
added
Enhancement
Sponsored
joakime
reviewed
Oct 27, 2022
jetty-server/src/main/java/org/eclipse/jetty/server/handler/SizeLimitHandler.java
Outdated
Show resolved
Hide resolved
joakime
reviewed
Oct 27, 2022
| if (contentLength < 0) | ||
| contentLength = baseRequest.getHttpFields().getLongField("X-Content-Encoding"); | ||
| if (contentLength > _requestLimit) | ||
| throw new BadMessageException(413, "Request Body too large"); |
There was a problem hiding this comment.
Order of interceptors is important.
If this is after the GzipHandler then you are basing the limits on uncompressed request/response.
Before the GzipHandler and you are basing the limits on raw network bytes.
Right?
Seems like an important detail for the javadoc.
There was a problem hiding this comment.
yeah, I removed the special handling for X-Content-Encoding, as that muddied the picture. I'll add some javadoc.
added tests
+ Improved javadoc + single interceptor instance + wrapped response
jetty-server/src/main/java/org/eclipse/jetty/server/handler/SizeLimitHandler.java
Outdated
Show resolved
Hide resolved
|
@lachlan-roberts can you re-review |
lachlan-roberts
approved these changes
Oct 31, 2022
|
Don't forget to add PRs and Issues to projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SizeLimitHandler