Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registration): fix where condition of getCompanyRolesAgreementConsents #327

Conversation

ntruchsess
Copy link
Contributor

Description

Query GetCompanyRoleAgreementConsentStatusUntrackedAsync has been adjusted to refer to companyId instead of userId in the where-condition

Why

Commit a67ba94 (PR #288) did break registration-endpoint GET companyRoleAgreementConsents by passing companyId instead of userId to the respective query. This has been discovered in TEST-1483

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

Sorry, something went wrong.

@ntruchsess ntruchsess force-pushed the bugfix/TEST-1483-companyRoleConsents branch from 44fc51b to 882b96b Compare November 6, 2023 09:45
@ntruchsess ntruchsess force-pushed the bugfix/TEST-1483-companyRoleConsents branch from 882b96b to b92029f Compare November 6, 2023 09:48
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ntruchsess ntruchsess marked this pull request as ready for review November 6, 2023 09:58
@ntruchsess ntruchsess requested a review from Phil91 November 6, 2023 09:58
@ntruchsess ntruchsess merged commit d8b9f02 into eclipse-tractusx:release/v1.7.0-RC3 Nov 6, 2023
4 checks passed
@ntruchsess ntruchsess deleted the bugfix/TEST-1483-companyRoleConsents branch November 6, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants