[#112]Corrected skip methods behavior of JsonParserImpl;

[api-from-the-ion]

Corrected the behavior of the skip methods in the parser implementation

[api-from-the-ion]

I'm writing the tests here, and I'm missing Junit 5 dearly. My question: could we move to Junit 5? This should be just a simple work of changing dependencies and modifying the 380 tests to use annotations and so on.

[jansupol]

That is a self-explanatory name :(

[api-from-the-ion]

Yes, I know. ;-) But what else should I write here? This is a fixture class for the tests involving the parser, so many of them. I don't like to repeat this try-with-resource line over and over again.

Or did you mean like we don't need the JavaDoc for the class itself, only the methods of this particular class? I mean, it's maybe not necessary, but this comment also doesn't hurt anybody, right? ;-)

[lukasj]

• avoid whitespace changes - use spaces and not tabs
• avoid static imports - they just make reviewers life more difficult when mixed with other changes
• are pom updates required here? they are usually handled through separate PRs (or through PRs which are to be just rebased instead of being squashed)

[lukasj]

My question: could we move to Junit 5? This should be just a simple work of changing dependencies and modifying the 380 tests to use annotations and so on.

If someone provides PR for this, I see no reason to not to move there.

[api-from-the-ion]

• avoid whitespace changes - use spaces and not tabs

  • avoid static imports - they just make reviewers life more difficult when mixed with other changes

  • are pom updates required here? they are usually handled through separate PRs (or through PRs which are to be just rebased instead of being squashed)

• I'll convert them. Yasson using the Checkstyle rule for this - shouldn't it be activated here also?
• I remove the static imports and make a commit
• Should I create a new branch with POM changes and cherry-pick these changes over there? I forgot to create a branch for my changes and done it on the changes on the master directly. ;-(

P.S.: Created a branch with Checkstyle. It has immediately 468 errors. Could anybody take a look on the rules, if they are OK? If so, I would correct the errors and make a PR of corrections and Checkstyle.

[api-from-the-ion]

If someone provides PR for this, I see no reason to not to move there.

OK, so we don't need some ticket for this? Just the PR full of commits to review? And another question: should I create a branch from the current master or is it OK, to fork some of the branches?

I see, I explained myself not so clearly. I have two (independent) changes in my mind. First: to update a JUnit. And independently, move from "inherit from TestCase" schema to the "use annotations" schema on tests. Anybody has some objections on the second case?