Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] SDO potential memory leak fix 2.0 - backport from the master #1866

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

rfelcman
Copy link
Contributor

This change solve potential memory leak if SDO component is used in JEE environment. There is refactor of SDOHelperContext.helperContexts map content (nested map). Instead of current ConcurrentHashMap is CacheIdentityMap used which supports Least Recently Used (LRU) strategy. This one should be controlled by new SDO system property eclipselink.sdo.helper.contexts.max.size.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
susnux Ferdinand Thiessen
This change solve potential memory leak if SDO component is used in JEE environment.
There is refactor of SDOHelperContext.helperContexts map content (nested map). Instead of current ConcurrentHashMap is CacheIdentityMap used which supports Least Recently Used (LRU) strategy. This one should be controlled by new SDO system property eclipselink.sdo.helper.contexts.max.size.

Signed-off-by: Radek Felcman <radek.felcman@oracle.com>
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit ee5be0b into eclipse-ee4j:2.7 Apr 25, 2023
@rfelcman rfelcman deleted the sdo_mem_leak_2.7 branch April 25, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants