Add ignoreCssSelectors option #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for easyops-cn-docusaurus-search-local ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cyriuz
force-pushed
the
add-ignoreClasses-option
branch
from
eef8a7e
to
e9f7794
Compare
|
@weareoutman do you think you'll have time to look at this? I'm just thinking if I should look into deploying it as a fork. |
weareoutman
reviewed
Sep 8, 2023
README.md
Outdated
| @@ -87,6 +87,7 @@ module.exports = { | |||
| | searchResultContextMaxLength | number | `50` | Set the max length of characters of each search result to show. | | |||
| | explicitSearchResultPath | boolean | `false` | Whether an explicit path to a heading should be presented on a suggestion template. | | |||
| | ignoreFiles | string \| RegExp \| (string \| RegExp)[] | `[]` | Set the match rules to ignore some routes. Put a string if you want an exact match, or put a regex if you want a partial match. Note: without the website base url. | | |||
| | ignoreClasses | string \| string[] | `[]` | A list of html classes to ignore when indexing each page. | | |||
There was a problem hiding this comment.
Thanks for your contributions! How about change this option to ignoreCssSelectors? So that users can ignore not only by classes, but also by other css selectors?
There was a problem hiding this comment.
Good idea, not sure why I didn't do that from the start :) Fixed it!
…s selector instead of just classes
Cyriuz
force-pushed
the
add-ignoreClasses-option
branch
from
f8605c6
to
4e2bc60
Compare
weareoutman
approved these changes
Sep 9, 2023
|
Thanks, released v0.36.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself in need of ignoring more custom elements from the search indexing so I thought this would be a good additional option to make the plugin even more flexible.
I also took the time to fix so that the tests complete fine on Windows with the differing path separators.