-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBP: first action #843
DBP: first action #843
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me overall
@muodov I narrowed some of the types as you suggested - but I don't think there's anything else blocking here? |
@shakyShane no blockers, it looks good. I understand that these scripts will only be run on select pages, right? If so, we can be less worried about webcompat issues in the wild. |
@muodov yeah that's correct - these are never going to be enabled for general users. |
https://app.asana.com/0/0/1206000767975136/f
Feature Summary
Native platforms will send one of the following instructions, one at a time:
navigate
extract
click
<- included in this PRexpectation
fillForm
getCaptchaInfo
solveCaptcha
Each of them has a corresponding function that will be executed, and will return either a SuccessResponse or ErrorResponse to native.
The flow looks like this: (taken from the markdown file in the PR)