Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualify compile_error! #1431

Merged
merged 2 commits into from Mar 30, 2023
Merged

Qualify compile_error! #1431

merged 2 commits into from Mar 30, 2023

Conversation

smoelius
Copy link
Contributor

Proposed fix for #1427

taiki-e
taiki-e reviewed Mar 30, 2023
View reviewed changes
src/error.rs Outdated
TokenStream::from_iter(vec![
TokenTree::Ident(Ident::new("std", start)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use core instead of std. Otherwise, it will generate an ugly error message in #![no_std] crate.

@dtolnay dtolnay linked an issue Mar 30, 2023 that may be closed by this pull request
cannot find macro compile_error in this scope #1427
Closed
dtolnay
dtolnay approved these changes Mar 30, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 4d1fd26 into dtolnay:master Mar 30, 2023
17 checks passed
@smoelius smoelius deleted the compile-error branch March 30, 2023 23:10
@smoelius smoelius mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot find macro compile_error in this scope
3 participants
@smoelius @dtolnay @taiki-e