Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dereference symlink on copying .npmrc and .yarnrc in makePatch #402

Merged
merged 1 commit into from
Sep 28, 2022
Merged

dereference symlink on copying .npmrc and .yarnrc in makePatch #402

merged 1 commit into from
Sep 28, 2022

Conversation

jimmyltsinn
Copy link
Contributor

Our team was facing problem on making patch, in which the package is hosted in private registry. We have noticed that #152 has already handle such scenario, but we are still facing error with message similar as #300

After checking, we notice that since our .npmrc is symlink to somewhere else (as to facilitate switch registry), we use symlink which is copied into the tmp folder during make patch, and thus the symlink cannot resolve.

This PR uses node fs copySync dereference flag (https://github.com/jprichardson/node-fs-extra/blob/master/docs/copy-sync.md) to dereference the symlink

Thanks

@orta
Copy link
Collaborator

orta commented Sep 28, 2022

Thanks for the useful writeup, and links to the docs - this makes sense to me 👍🏻

@orta orta merged commit 1486859 into ds300:master Sep 28, 2022
@ds300
Copy link
Owner

ds300 commented Oct 25, 2022

This was just released in v6.5.0! Thanks for your contribution 🙏🏼 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants