Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG, Neon] Rename Neon Auth schema #4064

Merged

Conversation

pffigueiredo
Copy link
Contributor

Description

This PR aims to fix an issue caused by Neon renaming the internal schema neon_identity to neon_auth.

FIX

  • Renamed the pre-defined schema internally, from neon_identity to neon_auth.

NOTES

  • Neon will be launching the Neon Auth feature in the upcoming days, so it would be nice if we could publish a patch with this in the next couple of days 🙏

Test Plan

Adapted existing tests to use neon_auth.

Subscribers

cc @davidgomes

Issue

Closes #4063

Rename Neon Auth schema from `neon_identity` to `neon_auth`
@AndriiSherman
Copy link
Member

@pffigueiredo If someone is already using previous schemas, maybe we don't need remove them but instead mark them as deprecated and provide a brief explanation of why they were deprecated. This way, we allow time for migration while also enabling a fast release of this feature in a patch update

@pffigueiredo
Copy link
Contributor Author

@pffigueiredo If someone is already using previous schemas, maybe we don't need remove them but instead mark them as deprecated and provide a brief explanation of why they were deprecated. This way, we allow time for migration while also enabling a fast release of this feature in a patch update

We probably don't need to be that cautious, since we already "broke" things on our end, as in, we renamed neon_identity in favor of neon_auth and it's already in production. 👀

@AndriiSherman AndriiSherman merged commit 555e4ff into drizzle-team:main Feb 5, 2025
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: fix schema name of Neon Auth to neon_auth
2 participants