Support WASM #275
Support WASM #275
Conversation
build.gradle.kts
Outdated
| @@ -11,6 +14,17 @@ plugins { | |||
| alias(libs.plugins.ksp) apply false | |||
| } | |||
|
|
|||
| plugins.withType<NodeJsRootPlugin> { | |||
| extensions.getByType<NodeJsRootExtension>().apply { | |||
| nodeVersion = "22.0.0-v8-canary202312089dd1cd78d4" | |||
There was a problem hiding this comment.
Does this affect published artifacts, or only the test runtime? I tried to find a way to apply the canary version only to the wasmJs targets, to avoid affecting the js targets, but that doesn't seem to be possible.
If it affects published artifacts, it may not be a good idea to merge this right now...
There was a problem hiding this comment.
Updated to a v21 canary version, but the same question applies.
There was a problem hiding this comment.
It's only for local testing. Doesn't make it into anything published.
A canary version is needed until nodejs/node#50115 lands.
The compiler was automatically generating these implicit casts for other targets, but not for WASM.
WASM requires a canary Node.js version. This is the last v21 canary, and has both darwin-arm64 and darwin-x64 artifacts.
drewhamilton
force-pushed
the
drew/wasm
branch
from
6c5771d to
ebead43
Compare
From the linked Slack thread—turns out I should have included the |
Closes #235.
Adds the
wasmJstarget to the:poko-annotationsand:poko-testsprojects.Adds explicit
irImplicitCastcalls afterirIschecks to avoid compile errors: the WASM target doesn't generate these automatically like other targets do. I posted a public Slack message about it here.The WASM target currently requires a canary Node.js version. I'm unclear on the implications of shipping with this, will follow up in this PR's comments.