From 5766f6b17aac1da80302840416e24ac9a341742c Mon Sep 17 00:00:00 2001 From: Damien Regad Date: Fri, 17 Mar 2023 12:17:32 +0100 Subject: [PATCH] PDO firebird: remove unnecessary methods - _init() did not actually initialize anything useful, as the $pdoDriver property was not used anywhere. - _affectedrows() was likely introduced by mistake (copy/paste error when the driver was refactored in 2019), as it references Firebird native (non-PDO) function fbird_affected_rows(), as discussed in #935. This fixes PHP 8.2 deprecation warnings due to undefined properties. --- drivers/adodb-pdo_firebird.inc.php | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/adodb-pdo_firebird.inc.php b/drivers/adodb-pdo_firebird.inc.php index 0ee5e02b6..f8847c3cc 100644 --- a/drivers/adodb-pdo_firebird.inc.php +++ b/drivers/adodb-pdo_firebird.inc.php @@ -32,14 +32,6 @@ class ADODB_pdo_firebird extends ADODB_pdo var $arrayClass = 'ADORecordSet_array_pdo_firebird'; - function _init($parentDriver) - { - $this->pdoDriver = $parentDriver; - //$parentDriver->_bindInputArray = true; - //$parentDriver->hasTransactions = false; // // should be set to false because of PDO SQLite driver not supporting changing autocommit mode - //$parentDriver->hasInsertID = true; - } - /** * Gets the version iformation from the server * @@ -243,12 +235,6 @@ public function dropSequence($seqname = 'adodbseq') return $this->Execute("DROP SEQUENCE $seqname"); } - - public function _affectedrows() - { - return fbird_affected_rows($this->_transactionID ? $this->_transactionID : $this->_connectionID); - } - public function genId($seqname = 'adodbseq', $startID = 1) { $getnext = ("SELECT Gen_ID($seqname,1) FROM RDB\$DATABASE");