Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Enable reading AE date as DateOnly #2275

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Dec 18, 2023

fixes #2274

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Dec 18, 2023

@JRahnama FYI!

@JRahnama JRahnama added this to the 5.2.0-preview5 milestone Dec 18, 2023
@JRahnama JRahnama changed the title enable reading AE date as DateOnly Fix | Enable reading AE date as DateOnly Dec 18, 2023
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Dec 18, 2023

@JRahnama I isolated the tests...

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5794ab3) 72.65% compared to head (6bfcac2) 72.53%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   72.65%   72.53%   -0.13%     
==========================================
  Files         310      310              
  Lines       62045    62045              
==========================================
- Hits        45081    45004      -77     
- Misses      16964    17041      +77     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.73% <100.00%> (-0.16%) ⬇️
netfx 69.89% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 12, 2024

@David-Engel Still plan to include this in preview 5?

@DavoudEshtehari DavoudEshtehari merged commit b12b15d into dotnet:main Jan 12, 2024
148 checks passed
JRahnama pushed a commit to JRahnama/SqlClient that referenced this pull request Jan 26, 2024
JRahnama pushed a commit to JRahnama/SqlClient that referenced this pull request Jan 26, 2024
# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidCastException when Reading Encrypted Date Column in with Entity Framework
5 participants