Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Fix managed instance TVP test source file #1878

Merged

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Jan 4, 2023

Managed instances are more similar to on premises databases. The DBCC flags is not same as azure dbs.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 70.84% // Head: 70.21% // Decreases project coverage by -0.62% ⚠️

Coverage data is based on head (03a8edf) compared to base (f0f2cbc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   70.84%   70.21%   -0.63%     
==========================================
  Files         292      292              
  Lines       61728    61728              
==========================================
- Hits        43729    43344     -385     
- Misses      17999    18384     +385     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.42% <ø> (-0.80%) ⬇️
netfx 69.06% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-21.43%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-21.08%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-15.91%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 82.14% <0.00%> (-14.29%) ⬇️
...ta/SqlClient/SqlConnectionPoolGroupProviderInfo.cs 42.50% <0.00%> (-5.00%) ⬇️
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs 78.22% <0.00%> (-2.42%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 62.62% <0.00%> (-2.32%) ⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs 89.13% <0.00%> (-2.18%) ⬇️
...soft/Data/SqlClient/TdsParserStateObjectManaged.cs 84.02% <0.00%> (-1.39%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-1.18%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the BUILDGUIDE as well.

Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@JRahnama JRahnama added the ✔️ Tests Identifier for test related changes label Jan 4, 2023
@JRahnama JRahnama changed the title Fix managed instance source file Test | Fix managed instance source file Jan 4, 2023
@DavoudEshtehari DavoudEshtehari changed the title Test | Fix managed instance source file Test | Fix managed instance TVP test source file Jan 4, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.1.0 milestone Jan 17, 2023
@DavoudEshtehari DavoudEshtehari merged commit 8e9f3c0 into dotnet:main Jan 17, 2023
@JRahnama JRahnama deleted the fix-managed-instance-source-file branch September 8, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Tests Identifier for test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants