Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.0.201
Choose a base ref
...
head repository: dotnet/sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.0.202
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 6, 2025

  1. Updating branding to 9.0.202 and downgrading the implicit version to … 

    …match the March release
    @marcpopMSFT
    marcpopMSFT committed Mar 6, 2025

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    chrischdi Christian Schlotter
    GPG key ID: 0E487122453EB0AC
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    774538c View commit details

Commits on Mar 7, 2025

  1. Update Roslyn version to include the dotnet format fix

    @marcpopMSFT
    marcpopMSFT committed Mar 7, 2025
    Copy the full SHA
    19b6982 View commit details

Commits on Mar 11, 2025

  1. Merged PR 48312: NuGetPackageDownloader: Only verify signing on windo… 

    …ws by default (#47321)

NuGetPackageDownloader: Only verify signing on windows by default (#47321)

Co-authored-by: Noah Gilson <OTAKUPENGUINOP@GMAIL.COM>
Co-authored-by: Forgind <12969783+Forgind@users.noreply.github.com>

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix to ensure package signing verification is only performed on Windows by default.

#### PR Summary
This pull request modifies the `NuGetPackageDownloader` to verify package signing only on Windows by default, with an option to enable it on other operating systems via an environment variable.
- `src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs`: Added logic to conditionally verify package signatures based on the operating system and environment variable. Introduced error handling to delete the package file if verification fails.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
    @marcpopMSFT
    marcpopMSFT committed Mar 11, 2025
    Copy the full SHA
    3a53853 View commit details
Loading