Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] [BrowserDebugProxy] Remove exception details from error report #111202

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Backport of #111169 to release/9.0-staging

/cc @mdh1418

Customer Impact

  • Customer reported
  • Found internally

Removes exception details from BrowserDebugProxy error reports to telemetry. We only need to quantify how often users hit BrowserDebugProxy's limitations with evaluating expressions.

Regression

  • Yes
  • No

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

Low, this simplifies the reports. The impacted customers are those debugging a .NET blazorwasm app that use the VS/VS Code debugger extension and hit the BrowserDebugProxy's expression evaluation limitation.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Sorry, something went wrong.

Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in 9.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jan 8, 2025
@jeffschwMSFT jeffschwMSFT added this to the 9.0.x milestone Jan 8, 2025
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 8, 2025
@jeffschwMSFT jeffschwMSFT modified the milestones: 9.0.x, 9.0.2 Jan 8, 2025
@jeffschwMSFT jeffschwMSFT merged commit 3e297bc into release/9.0-staging Jan 8, 2025
10 checks passed
@jkotas jkotas deleted the backport/pr-111169-to-release/9.0-staging branch January 8, 2025 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants