Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0-staging][wasm] Workaround incorrect mono restore when building WBT #110590

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[release/9.0-staging][wasm] Workaround incorrect mono restore when building WBT #110590

merged 2 commits into from
Dec 20, 2024
+6 −1

Conversation

lewing
Copy link
Member

@lewing lewing commented Dec 10, 2024

No description provided.

@lewing lewing mentioned this pull request Dec 10, 2024
Merged
@carlossanlop
Copy link
Member

Is staging correct? We don't want it to go straight to base?

@lewing
Copy link
Member Author

lewing commented Dec 10, 2024

test infrastructure only change

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Dec 10, 2024
@carlossanlop
Copy link
Member

Tell mode: infra only. Approved.

@lewing
Copy link
Member Author

lewing commented Dec 10, 2024

Is staging correct? We don't want it to go straight to base?

I'm happy to retarget?

@carlossanlop
Copy link
Member

I'm happy to retarget?

It depends on how urgent it is. Do we need it right now like the other PR you just merged?

@carlossanlop
Copy link
Member

If not, staging is fine and we can monitor the builds to see if it worked or not.

@lewing
Copy link
Member Author

lewing commented Dec 10, 2024

If not, staging is fine and we can monitor the builds to see if it worked or not.

it should make the tests green but it isn't required for the product

@carlossanlop
Copy link
Member

Oh I missed that it was for tests, sorry. Carry on then. Staging it is.

@akoeplinger
Copy link
Member

akoeplinger commented Dec 11, 2024 •
edited
Loading

There's a different failure now though:

dotnet_install: Error: Could not find .NET Core SDK with version = 9.0.102

@lewing
Copy link
Member Author

lewing commented Dec 11, 2024

There's a different failure now though:

dotnet_install: Error: Could not find .NET Core SDK with version = 9.0.102

I think the failure is a result of #109304 updating to an unreleased sdk

@lewing
Rollback the workload sdk version
Loading
Loading status checks…
9654cea
@build-analysis build-analysis bot mentioned this pull request Dec 12, 2024
Open
@akoeplinger akoeplinger merged commit 8af4dec into dotnet:release/9.0-staging Dec 20, 2024
157 checks passed
@akoeplinger akoeplinger mentioned this pull request Dec 20, 2024
Merged
@akoeplinger akoeplinger mentioned this pull request Jan 10, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop

@maraf maraf

@ilonatommy ilonatommy

@pavelsavara pavelsavara

@akoeplinger akoeplinger

Assignees

@lewing lewing

Labels
area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lewing @carlossanlop @akoeplinger @maraf