Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] handle case of Proc Index > MAX_SUPPORTED_CPUS #109385

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024

Backport of #109295 to release/9.0-staging

/cc @mangod9

Customer Impact

  • Customer reported
  • Found internally

The issue occurs mainly when running a x86 .NET app with ServerGC on a machine with > 64 cores. If the app is scheduled to run on the higher cpu group it could lead to an AV.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Verified locally on a machine with >64 cores. Additionally support and customer has validated the fix.

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Sorry, something went wrong.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 9.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Oct 30, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.x milestone Oct 30, 2024
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 6, 2024
@mangod9 mangod9 merged commit d31f394 into release/9.0-staging Nov 6, 2024
92 of 96 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 9.0.x, 9.0.1 Dec 11, 2024
@jkotas jkotas deleted the backport/pr-109295-to-release/9.0-staging branch December 29, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-GC-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants