[release/8.0] Free the tls memory on thread termination #95439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jkotas
approved these changes
Nov 30, 2023
JulieLeeMSFT
added
the
Servicing-consider
|
CC @jeffschwMSFT. |
|
cc @mangod9, @AndyAyersMS. |
carlossanlop
approved these changes
Nov 30, 2023
mangod9
approved these changes
Nov 30, 2023
JulieLeeMSFT
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95362 to release/8.0
/cc @kunalspathak
Customer Impact
Thread Local Static (TLS) is a new feature we added in .NET 8. The TLS memory that we used to store the TLS data per thread was never freed on thread termination. This results in memory leak. This PR fixes the memory leak issue in .NET 8 as reported by one of our internal partner. It will block them on for their January deployment without this fix.
Testing
CI and verified with the internal partner who reported the issue. With the fix, it doesn't leak memory for them.
Risk
It is less risky because we will now free the thread local memory only during the thread termination of the executing thread.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0. (had to targetrelease/8.0for quicker turnaround).If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.