Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] HostActivation Tests windows x86 build failure #81851

Open
carlossanlop opened this issue Feb 8, 2023 · 11 comments
Open

[6.0] HostActivation Tests windows x86 build failure #81851

carlossanlop opened this issue Feb 8, 2023 · 11 comments
Labels
arch-x86 area-Infrastructure-coreclr Known Build Error Use this to report build issues in the .NET Helix tab os-windows

Comments

@carlossanlop
Copy link
Member

carlossanlop commented Feb 8, 2023

Error message:

XUnit : error : Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86] [D:\a\_work\1\s\src\installer\tests\HostActivation.Tests\HostActivation.Tests.csproj]
##[error]XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86]

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Build Definition Test Pull Request
2458479 dotnet-runtime Microsoft.DotNet.CoreSetup.Test.HostActivation.SDKLookup.SdkLookup_Must_Pick_The_Highest_Semantic_Version #39678
681892 dotnet/runtime Microsoft.DotNet.CoreSetup.Test.HostActivation.MultilevelSDKLookup.SdkMultilevelLookup_Global_Json_Single_Digit_Patch_Rollup #102466
680906 dotnet/runtime Microsoft.DotNet.CoreSetup.Test.HostActivation.SDKLookup.SdkLookup_Negative_Version #102435
665394 dotnet/runtime Microsoft.DotNet.CoreSetup.Test.HostActivation.MultilevelSDKLookup.SdkMultilevelLookup_Global_Json_Single_Digit_Patch_Rollup #101822
663479 dotnet/runtime Microsoft.DotNet.CoreSetup.Test.HostActivation.SDKLookup.SdkLookup_Global_Json_Single_Digit_Patch_Rollup #101813

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 5

Known issue validation

Build: 🔎
Result validation: ⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 8, 2023
@carlossanlop carlossanlop added Known Build Error Use this to report build issues in the .NET Helix tab and removed area-Host untriaged New issue has not been triaged by the area owner labels Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Error message:

XUnit : error : Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86] [D:\a\_work\1\s\src\installer\tests\HostActivation.Tests\HostActivation.Tests.csproj]
##[error]XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86]
{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Tests failed: .+\\HostActivation\.Tests_net6\.0_x86\.html",
  "ExcludeConsoleLog": false
}
Author: carlossanlop
Assignees: -
Labels:

area-Host

Milestone: -

@vitek-karas
Copy link
Member

The actual failure is:

System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied.
   at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
   at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.MultilevelSDKLookup.Dispose() in /_/src/installer/tests/HostActivation.Tests/MultilevelSDKLookup.cs:line 87
   at ReflectionAbstractionExtensions.DisposeTestClass(ITest test, Object testClass, IMessageBus messageBus, ExecutionTimer timer, CancellationTokenSource cancellationTokenSource) in /_/src/xunit.execution/Extensions/ReflectionAbstractionExtensions.cs:line 87

This looks a lot like robustness things we've been working on for a while and sort of solved in 7/8 where I don't remember seeing failures like this at all recently. I don't know if it's worth the effort to try to backport all of these test infra fixes.

Short version: I'm pretty sure this is not a product issue, but it's a test infra issue.

@elinor-fung who also worked on the test infra robustness for another opinion.

@elinor-fung
Copy link
Member

Yeah, this looks like test robustness issues we were chasing (and haven't seen recently) - not anything in the product. I'm also not sure if it is worth backporting the various fixes we've made, particularly since the failures are on cleanup, so by the time they are hit, the actual validation has been done/passed.

@carlossanlop if this starts happening in a lot in 6.0 PRs (hoping not based on the current hit count) and it slows you down too much, I can investigate what we would need to backport.

@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Error message:

XUnit : error : Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86] [D:\a\_work\1\s\src\installer\tests\HostActivation.Tests\HostActivation.Tests.csproj]
##[error]XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Debug\HostActivation.Tests_net6.0_x86.html [net6.0|x86]

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Tests failed: .+\\HostActivation\.Tests_net6\.0_x86\.html",
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
Author: carlossanlop
Assignees: -
Labels:

arch-x86, os-windows, area-Infrastructure-coreclr, Known Build Error

Milestone: -

@hoyosjs
Copy link
Member

hoyosjs commented Mar 4, 2023

I didn't update the error blob, it's a bit too broad and will catch any error in the assembly. But the correct encoding was:

{
  "BuildRetry": false,
  "ErrorPattern": "Tests failed: .+\\\\HostActivation\\.Tests_net\\d\\.0_(x64|x86|arm64)+\\.html",
  "ExcludeConsoleLog": false
}

@carlossanlop
Copy link
Member Author

carlossanlop commented May 16, 2023

@hoyosjs I changed the error blob to what you suggested.

Still seeing this failure. It was hit in this 6.0 PR: #86295

@carlossanlop carlossanlop added Known Build Error Use this to report build issues in the .NET Helix tab and removed Known Build Error Use this to report build issues in the .NET Helix tab labels May 16, 2023
@akoeplinger
Copy link
Member

The error pattern seems to match all failures in the installer tests, e.g. this main PR https://github.com/dotnet/runtime/pull/85913/checks?check_run_id=13522623704 even though that fails with a different failure.

@hoyosjs
Copy link
Member

hoyosjs commented May 17, 2023

Sadly, multiline regex isn't supported to glob that it's hosting and comprises activation issues...

@carlossanlop
Copy link
Member Author

Ok let me revert the pattern and use x86 specifically.
I'll create a new issue for the x64 one happening in main.

@elinor-fung
Copy link
Member

I updated the error pattern to reflect the specific UnauthorizedAccessException that was being hit in 6.0.
The table in the description still has all the ones that were unintentionally linked before, but I think it should be filtered to what we want going forward.

@carlossanlop
Copy link
Member Author

@elinor-fung there's another hit in 6.0, specifically in the branding PR for 6.0.26: #94482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x86 area-Infrastructure-coreclr Known Build Error Use this to report build issues in the .NET Helix tab os-windows
Projects
None yet
Development

No branches or pull requests

6 participants