Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add windows runtime packs as a workload #69393

Merged
merged 1 commit into from May 16, 2022

Conversation

steveisok
Copy link
Member

@steveisok steveisok commented May 16, 2022

Backport of #68981

Customer Impact

At certain points in time internally, the sdk will rev its version and insert into VS. It's at this point the sdk version will be ahead of the runtime version as we have not published anything into nuget. In MAUI and WinUI scenarios, this creates a bit of a pickle as the sdk will try to download a new version of the windows runtime pack, but it will not be available.

To get around this limitation, we are introducing a workload that will be inserted into VS where you can optionally install Windows runtime packs.

Testing

Manual validation the workload artifacts contains the windows workload.

Risk

Low

Backport of dotnet#68981

At certain points in time internally, the sdk will rev its version and insert into VS. It's at this point the sdk version will be ahead of the runtime version as we have not published anything into nuget. In MAUI and WinUI scenarios, this creates a bit of a pickle as the sdk will try to download a new version of the windows runtime pack, but it will not be available.

To get around this limitation, we are introducing a workload that will be inserted into VS where you can optionally install Windows runtime packs.
@ghost
Copy link

ghost commented May 16, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #68981

At certain points in time internally, the sdk will rev its version and insert into VS. It's at this point the sdk version will be ahead of the runtime version as we have not published anything into nuget. In MAUI and WinUI scenarios, this creates a bit of a pickle as the sdk will try to download a new version of the windows runtime pack, but it will not be available.

To get around this limitation, we are introducing a workload that will be inserted into VS where you can optionally install Windows runtime packs.

Author: steveisok
Assignees: steveisok
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok steveisok added Servicing-consider Issue for next servicing release review and removed area-Infrastructure-mono labels May 16, 2022
@marek-safar marek-safar added this to the 6.0.x milestone May 16, 2022
@mmitche
Copy link
Member

mmitche commented May 16, 2022

Code complete is today, plese get this in.

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 16, 2022
@steveisok
Copy link
Member Author

Approved over email

@steveisok steveisok requested a review from lewing May 16, 2022 19:36
@carlossanlop carlossanlop merged commit 4b7cc43 into dotnet:release/6.0 May 16, 2022
@RussKie
Copy link
Member

RussKie commented May 16, 2022

FYI @merriemcgaw @dotnet/dotnet-winforms @dotnet/wpf-developers

@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants