Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Docker fixes for the enterprise linux testing pipeline #68913

Merged
merged 3 commits into from May 16, 2022

Conversation

akoeplinger
Copy link
Member

Backport of #65981, #68311 and #68875 to release/6.0

Customer Impact

We started getting warnings in the build about using images from docker directly, see docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis.

Eventually these will be turned into errors and will break the build at that point so we need to backport this before that happens.

/cc @dotnet/runtime-infrastructure

Testing

Tested in main and this PR.

Risk

Very low, it only affects a testing pipeline.

wfurt and others added 3 commits May 5, 2022 18:02
* attemp to fix up EnterpriseTests

* fix text

* increase timoeout on build step

* fix temeout

* add jobs

* update job

* fix formating

* fix name

* update server check

* restore original resolver before tests

* fix path

* experiment

(cherry picked from commit 9174037)
…8875)

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

(cherry picked from commit bafae1b)
@akoeplinger akoeplinger added this to the 6.0.x milestone May 5, 2022
@akoeplinger akoeplinger requested a review from wfurt May 5, 2022 16:10
@ghost ghost assigned akoeplinger May 5, 2022
@ghost
Copy link

ghost commented May 5, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #65981, #68311 and #68875 to release/6.0

Customer Impact

We started getting warnings in the build about using images from docker directly, see docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis.

Eventually these will be turned into errors and will break the build at that point so we need to backport this before that happens.

/cc @dotnet/runtime-infrastructure

Testing

Tested in main and this PR.

Risk

Very low, it only affects a testing pipeline.

Author: akoeplinger
Assignees: -
Labels:

area-System.Net.Security

Milestone: 6.0.x

@akoeplinger
Copy link
Member Author

/azp run runtime-libraries enterprise-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -60,6 +60,9 @@ services:
hostname: linuxclient
domainname: linux.contoso.com
dns_search: linux.contoso.com
privileged: true
dns:
- 8.8.8.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a backport but I just wanted to make sure that we are ok with using the Google DNS here? cc @GrabYourPitchforks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is there specifically because of https://github.com/dotnet/core-eng/issues/15594
If we can fix the underlying problem and make DNS resolution work in our infrastructure, this could be removed.

@akoeplinger
Copy link
Member Author

@akoeplinger
Copy link
Member Author

akoeplinger commented May 5, 2022

this is a CI-only change so shouldn't need to go through tactics if I remember correctly

@carlossanlop
Copy link
Member

@akoeplinger there are CI failures. Are they related to this change? If not, let me know, and I can merge if you think this is ready. cc @ViktorHofer

@akoeplinger
Copy link
Member Author

@carlossanlop the failure is unrelated, it's a flaky test that was disabled in main: #65588

@carlossanlop carlossanlop merged commit 0dc7e3b into dotnet:release/6.0 May 16, 2022
@akoeplinger akoeplinger deleted the enterprise-linux-6.0 branch May 24, 2022 16:22
@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants