Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spurious net6.0-windows7 folders #1887

Closed
idg10 opened this issue Mar 11, 2023 · 2 comments
Closed

Remove spurious net6.0-windows7 folders #1887

idg10 opened this issue Mar 11, 2023 · 2 comments
Labels
[area] Rx
Milestone
Rx 6.0

Comments

@idg10
Copy link
Collaborator

idg10 commented Mar 11, 2023

The Rx 6.0 preview.1 build has net6.0-windows7 folders underneath both build and buildTransitive that we suspect should not be present.

First, work out why they are there - it looks like the previous version had something equivalent. If that's true, work out what purpose they served. It's conceivable that they do actually need to be there. But if we don't need them, remove them.
@idg10 idg10 added this to the Rx 6.0 milestone Mar 11, 2023
@idg10
Copy link
Collaborator Author

idg10 commented Mar 13, 2023

Ah, turns out that these were introduced by #1442, but the reason Rx 5.0.0 doesn't have these folders is that #1442 was merged after the last release of Rx! (So although it was merged, it never shipped.)

As per the discussion in #1889 (comment) it's looking like we probably don't want to keep that change. Backing that out should have the side effect of removing these folders from the package.

@idg10
Copy link
Collaborator Author

idg10 commented Mar 30, 2023

Fixed in #1901

@idg10 idg10 closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[area] Rx
Projects
None yet
Milestone
Rx 6.0
Development

No branches or pull requests
1 participant
@idg10