Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal and C#-only warning levels shown for F# projects #9469

Open
abelbraaksma opened this issue May 15, 2024 · 0 comments
Open

Illegal and C#-only warning levels shown for F# projects #9469

abelbraaksma opened this issue May 15, 2024 · 0 comments
Assignees
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Triage-Approved Reviewed and prioritized
Milestone

Comments

@abelbraaksma
Copy link

abelbraaksma commented May 15, 2024

Visual Studio Version

Visual Studio Version 17.8.6
and 17.10.0 Preview 7.0

Summary

The warning levels shown for an F# project are the ones for a C# project. Furthermore, these warning levels are invalid for F# (it uses only 1-5).

Steps to Reproduce

  1. Create or open an F# project
  2. Go to Properties page
  3. Select the dropdown box for Warning level

Expected Behavior

The F# warning levels.

Actual Behavior

The C# warning levels, some of which are invalid when selected.

1>FSC : error FS1050: Invalid warning level '7'

image

User Impact

At the least, confusion, at the worst, broken builds:

These were introduced after #7978 was implemented (through #7982 and #8004). Going over these PRs, there's nothing in these discussions (unless I missed it) that makes these options language-dependent, or, if they cannot be language-dependent, language agnostic.

I've no problem issuing a PR for this, but I'm not very familiar with this project and there doesn't seem to be a clear mechanism for these enums to be selected based on a current project language setting.

/cc @vzarytovskii

@smitpatel smitpatel added the Triage-Approved Reviewed and prioritized label May 16, 2024
@smitpatel smitpatel added the Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner label May 16, 2024
@smitpatel smitpatel added this to the 17.11 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests

3 participants