Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build acceleration for deps.json and runtimeconfig.json #9274

Open
KirillOsenkov opened this issue Sep 30, 2023 · 2 comments
Open

Build acceleration for deps.json and runtimeconfig.json #9274

KirillOsenkov opened this issue Sep 30, 2023 · 2 comments
Assignees
Labels
Triage-Approved Reviewed and prioritized
Milestone

Comments

@KirillOsenkov
Copy link
Member

I'm not sure if it's a bug or not, but if you have two projects, P1 and P2, P2 references P1, and P1 is an .exe project, should build acceleration copy P1.deps.json and P1.runtimeconfig.json to the P2 output directory when P2 is up-to-date?

I'm not seeing the deps.json and runtimeconfig.json files added in CollectCopyToOutputDirectoryItemDesignTime:

Same question for .exe.config for .NET framework .exe projects I guess?

@KirillOsenkov
Copy link
Member Author

Also for .dll file references that don't come from project references, the .pdb file doesn't seem to be included? MSBuild copies both the foo.dll and the foo.pdb if you use a , but I'm only seeing foo.dll in the CopyToOutputDirectoryItems.

Not sure if this is expected.

I'm trying to write a validator that checks that all files that were present in the output directory are accounted for by build acceleration. If there is a file that got there because it was previously copied by MSBuild, but build acceleration doesn't know about it, it means we have a gap in coverage.

I can imagine scenarios where the reference pdb is now stale and is no longer matching the .dll.

@KirillOsenkov
Copy link
Member Author

Also .dll.config and .runtimeconfig.dev.json

@tmeschter tmeschter added the Triage-Approved Reviewed and prioritized label Oct 5, 2023
@tmeschter tmeschter added this to the 17.9 milestone Oct 5, 2023
@drewnoakes drewnoakes modified the milestones: 17.9, 17.10 Feb 14, 2024
@drewnoakes drewnoakes modified the milestones: 17.10, 17.11 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests

3 participants