Always read grain state during activation if it has not been rehydrated #8944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
perf/statestoragebridge-lighten
branch
from
518d453
to
36c1f07
Compare
ReubenBond
changed the title
ReubenBond
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8936
This fixes the issue identified in #8936 where accessing state in the grain's constructor would cause it to not be loaded during activation. Additionally, trying to access
RecordExistsbefore a successful read has been issued will result in anInvalidOperationExceptionbeing thrown.This also reduces the number of fields in
StateStorageBridge<T>by moving fields which can be shared between multiple instances to a shared object.Microsoft Reviewers: Open in CodeFlow