Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Identify F# single case discriminated unions as SumType (#8739) #8757

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Dec 2, 2023

Backport of #8739 to 7.x

Microsoft Reviewers: Open in CodeFlow

Single case discriminated unions do not inherit from an abstract
base class, thus, for single case discriminated unions we need to
look for the CompilationMappingAttribute on the type itself.

Fix 8715
@ReubenBond ReubenBond merged commit 14e6489 into dotnet:7.x Dec 2, 2023
@ReubenBond ReubenBond deleted the v7/fsharp-single-case-du branch December 2, 2023 00:35
ReubenBond added a commit that referenced this pull request Dec 2, 2023
Single case discriminated unions do not inherit from an abstract
base class, thus, for single case discriminated unions we need to
look for the CompilationMappingAttribute on the type itself.

Fix 8715

Co-authored-by: Geir Fiksdal <geirfiks@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants