remove CreateBootstrap opting-in #10760
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks for the change!
I'm to blame for the wrong formulation of the bug.
CreateBootstrap property can only be used to opt-out from bootstrap creation. We still want to keep this behavior (and that mention in the doc)
Bootstrap is created by default - so explicit opt-in is rendundand and cinfusing - that's what we want to remove
documentation/wiki/Building-Testing-and-Debugging-on-Full-Framework-MSBuild.md
Outdated
Show resolved
Hide resolved
JanProvaznik
changed the title
JanProvaznik
changed the title
YuliiaKovalova
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10751
Context
Bootstrap is on by default, opt-in with arg
/p:CreateBootstrap=trueis unnecessaryChanges made
docs, CI: remove instances of
CreateBootstrap=true