Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use collection expressions in (non-test) sources #10758

Merged
merged 7 commits into from
Oct 8, 2024
Merged

use collection expressions in (non-test) sources #10758

merged 7 commits into from
Oct 8, 2024
+377 −393

Conversation

kasperk81
Copy link
Contributor

few places were missing the modern syntax. excluding tests.

@rainersigwald
Copy link
Member

All automated refactoring or did you do anything manually? (assessing risk here :))

rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it!

@kasperk81
Copy link
Contributor Author

All automated refactoring or did you do anything manually? (assessing risk here :))

all manual git grep -ln 'new\s*\w*\[\]' | grep -vi test, updated them by hand and then ran the build

rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
@kasperk81
enumerable.empty
Loading
Loading status checks…
2be114c
@kasperk81
fb
Loading
Loading status checks…
4e8f16d
rainersigwald
rainersigwald reviewed Oct 4, 2024
View reviewed changes
@kasperk81
Update src/Shared/ReadOnlyEmptyDictionary.cs
Loading
Loading status checks…
45de787
@kasperk81
fix
Loading
Loading status checks…
505380f
@kasperk81
use concrete type for private member

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6b15700
@YuliiaKovalova YuliiaKovalova merged commit eae7bbd into dotnet:main Oct 8, 2024
10 checks passed
@kasperk81 kasperk81 deleted the collection-expr branch October 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald

@JanKrivanek JanKrivanek

@YuliiaKovalova YuliiaKovalova

Assignees

@YuliiaKovalova YuliiaKovalova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kasperk81 @rainersigwald @JanKrivanek @YuliiaKovalova