Any have metadata value when empty Fixes #5113 #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when we saw the Item was empty, we'd jump out early. Fortunately, we already special-cased Count, and it turns out we can do the same with AnyHaveMetadataValue.
rainersigwald
approved these changes
Mar 28, 2023
src/Build/Evaluation/Expander.cs
Outdated
| @@ -1947,7 +1947,8 @@ private static class ItemExpander | |||
| if (itemsOfType.Count == 0) | |||
| { | |||
| // .. but only if there isn't a function "Count()", since that will want to return something (zero) for an empty list | |||
Forgind
commented
Mar 28, 2023
Forgind
added
the
merge-when-branch-open
rainersigwald
requested changes
Mar 28, 2023
Forgind
force-pushed
the
AnyHaveMetadataValue-when-empty
branch
from
345016e
to
e6f221a
Compare
Forgind
removed
the
merge-when-branch-open
|
Put it in the change wave. Scenarios I can think of where someone would be broken are a bit ridiculous like trying to use it as IsEmpty: I really hope no one does that. I skipped adding ChangeWave-specific tests; hopefully you're ok with that 🙂 |
rainersigwald
approved these changes
Mar 28, 2023
Forgind
added
the
merge-when-branch-open
Forgind
added a commit
to Forgind/sdk
that referenced
this pull request
Apr 5, 2023
AnyHaveMetadataValue returns an empty string if the item is empty. This is a bug fixed in dotnet/msbuild#8603, but this branch does not yet have that change. This workaround should be resilient whether or not the fix is in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5113
Context
AnyHaveMetadataValue returns empty when the itemgroup is empty, which doesn't make sense and doesn't match our documentation. This changes it to return false in that case.
Changes Made
If we see the function we're evaluating is AnyHaveMetadataValue, don't skip out early.
Testing
Made a unit test
Notes