Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The database default created by Migrations for primitive collections mapped to JSON is invalid #32972

Closed
ajcvickers opened this issue Jan 31, 2024 · 2 comments · Fixed by #33039
Closed

The database default created by Migrations for primitive collections mapped to JSON is invalid #32972

ajcvickers opened this issue Jan 31, 2024 · 2 comments · Fixed by #33039
Assignees
@maumar
Labels
area-json area-migrations customer-reported Servicing-approved type-bug
Milestone
8.0.4

Comments

@ajcvickers
Copy link
Contributor

See #32896 (comment)
@ajcvickers ajcvickers self-assigned this Jan 31, 2024
@ajcvickers ajcvickers assigned maumar and unassigned ajcvickers Jan 31, 2024
@ajcvickers ajcvickers added this to the 8.0.x milestone Jan 31, 2024
maumar added a commit that referenced this issue Feb 9, 2024
@maumar
Fix to #32972 - The database default created by Migrations for primit…
20d69fa 
…ive collections mapped to JSON is invalid

Problem was that when adding new required column to an existing table we always need to provide default value (to fill the values for rows already in the table). For collection of primitives that get map to json we should be setting the value to empty JSON collection, i.e. '[]' but we were not doing that.

Fixes #32972
@maumar maumar mentioned this issue Feb 9, 2024
Merged
maumar added a commit that referenced this issue Feb 9, 2024
@maumar
Fix to #32972 - The database default created by Migrations for primit…
bff6751 
…ive collections mapped to JSON is invalid

Problem was that when adding new required column to an existing table we always need to provide default value (to fill the values for rows already in the table). For collection of primitives that get map to json we should be setting the value to empty JSON collection, i.e. '[]' but we were not doing that.

Fixes #32972
maumar added a commit that referenced this issue Feb 10, 2024
@maumar
Fix to #32972 - The database default created by Migrations for primit…
28a95fc 
…ive collections mapped to JSON is invalid (#33039)

Problem was that when adding new required column to an existing table we always need to provide default value (to fill the values for rows already in the table). For collection of primitives that get map to json we should be setting the value to empty JSON collection, i.e. '[]' but we were not doing that.

Fixes #32972
@maumar
Copy link
Contributor

maumar commented Feb 10, 2024

reopening for patch

@maumar maumar reopened this Feb 10, 2024
maumar added a commit that referenced this issue Feb 10, 2024
@maumar
Fix to #32972 - The database default created by Migrations for primit…
1e56b22 
…ive collections mapped to JSON is invalid

Problem was that when adding new required column to an existing table we always need to provide default value (to fill the values for rows already in the table). For collection of primitives that get map to json we should be setting the value to empty JSON collection, i.e. '[]' but we were not doing that.
@maumar maumar mentioned this issue Feb 10, 2024
Merged
maumar added a commit that referenced this issue Feb 10, 2024
@maumar
moving tests for #32972 to relational so we also test SqLite

Verified

This commit was signed with the committer’s verified signature.
novemberborn Mark Wubben
SSH Key Fingerprint: vMGPTCc4s8qHvUbwn+BG4sx8ahyNN/1R52XsxINSNVk
Verified
Learn about vigilant mode
13346ba
maumar added a commit that referenced this issue Feb 11, 2024
@maumar
moving tests for #32972 to relational so we also test SqLite

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fd22d64
maumar added a commit that referenced this issue Feb 12, 2024
@maumar
moving tests for #32972 to relational so we also test SqLite (#33050)
c583d6b
@ajcvickers ajcvickers modified the milestones: 8.0.x, 8.0.4 Feb 15, 2024
maumar added a commit that referenced this issue Mar 5, 2024
@maumar
Fix to #32972 - The database default created by Migrations for primit…
406121f 
…ive collections mapped to JSON is invalid (#33048)

Problem was that when adding new required column to an existing table we always need to provide default value (to fill the values for rows already in the table). For collection of primitives that get map to json we should be setting the value to empty JSON collection, i.e. '[]' but we were not doing that.
@maumar
Copy link
Contributor

maumar commented Mar 5, 2024

merged to release/8.0, closing

@maumar maumar closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-json area-migrations customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
8.0.4
2 participants
@ajcvickers @maumar