Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Cosmos: Persist non-shadow int keys on owned entity types #31936

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

AndriySvyryd
Copy link
Member

Port of #31933
Fixes #31664

Description

When an owned entity type contains and int property that is configured as the key EF assumes that it is a client-generated ordinal that shouldn't be persisted.

Customer impact

For models with matching shape the key property values are replaced with ordinals, causing data loss.

How found

Customer reported on 6.0

Regression

No.

Testing

Added tests.

Risk

Low. Quirked.

@AndriySvyryd AndriySvyryd requested a review from a team October 3, 2023 00:37
@wtgodbe
Copy link
Member

wtgodbe commented Oct 4, 2023

@AndriySvyryd can you get a code review on this?

@ajcvickers ajcvickers merged commit 4070396 into release/6.0 Oct 4, 2023
@ajcvickers ajcvickers deleted the Issue31664 branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants