Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #31448 Use token for NonQueryResultAsync #31449

Merged
merged 1 commit into from Sep 25, 2023
Merged

Fix to #31448 Use token for NonQueryResultAsync #31449

merged 1 commit into from Sep 25, 2023

Conversation

dsgordeev
Copy link
Contributor

@dsgordeev dsgordeev commented Aug 12, 2023 •
edited

Fixes (#31448)

@dsgordeev
Use token for NonQueryResultAsync
36d7ba3 
   - Affects ExecuteDeleteAsync(token)
   - Affects ExecuteUpdateAsync(token)

Fixes [dotnet#31448](dotnet#31448)
@dsgordeev dsgordeev mentioned this pull request Aug 25, 2023
Closed
@dsgordeev dsgordeev changed the title Use token for NonQueryResultAsync [bug-fix] Use token for NonQueryResultAsync Sep 6, 2023
@dsgordeev dsgordeev changed the title [bug-fix] Use token for NonQueryResultAsync [release/7.0] Fix to #31448 Use token for NonQueryResultAsync Sep 20, 2023
@ajcvickers
Copy link
Member

@dsgordeev Please re-target this to the main branch.

@dsgordeev dsgordeev changed the base branch from release/7.0 to main September 22, 2023 19:54
@dsgordeev
Copy link
Contributor Author

@ajcvickers, it's done. Thanks for feedback.

@ajcvickers ajcvickers merged commit d2f824a into dotnet:main Sep 25, 2023
7 checks passed
@ajcvickers
Copy link
Member

Thanks!

@dsgordeev
Copy link
Contributor Author

Welcome! Very interesting framework to dive into. Especially in part of language translation (AST to SQL).

@dsgordeev dsgordeev deleted the use-token-for-non-query-result-async branch September 26, 2023 10:50
@roji roji changed the title [release/7.0] Fix to #31448 Use token for NonQueryResultAsync Fix to #31448 Use token for NonQueryResultAsync Nov 3, 2023
roji pushed a commit to roji/efcore that referenced this pull request Nov 17, 2023
@dsgordeev @roji
[release/7.0] Fix to dotnet#31448 Use token for NonQueryResultAsync (d…
e86509a 
…otnet#31449)

Fixes dotnet#31448

(cherry picked from commit d2f824a)
roji pushed a commit to roji/efcore that referenced this pull request Nov 17, 2023
@dsgordeev @roji
[release/7.0] Fix to dotnet#31448 Use token for NonQueryResultAsync (d…
ed8364f 
…otnet#31449)

Fixes dotnet#31448

(cherry picked from commit d2f824a)
@roji roji mentioned this pull request Nov 17, 2023
Merged
AndriySvyryd pushed a commit that referenced this pull request Nov 21, 2023
@roji @dsgordeev
[release/7.0] Fix to #31448 Use token for NonQueryResultAsync (#31449) (
e6291bf 
#32334)

Fixes #31448

(cherry picked from commit d2f824a)

Co-authored-by: Gordeev Dmitry <dmitrii.gordeev@redlab.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsgordeev @ajcvickers