[release/7.0] fixing a typo in quirk string for issue 30330 #30784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajcvickers do we need approval for stuff like this? |
maumar
changed the title
ajcvickers
approved these changes
Apr 28, 2023
|
@maumar Not sure. @danmoseley? |
|
@danmoseley do we need tactics approval for this? It's kind of a behavioral change, but it's so trivial it feels like we could get away with tell-mode |
|
this didn't ship yet, doesn't add any risk to customers or dates, you can just merge. tactics doesn't care if we make a fix with their approval then need to follow up to fix a typo, so long as it didn't ship yet/ doesn't affect dates. |
|
@ajcvickers pointed out the the original change will ship ahead of this fix. in that case I suggest either to accept both (the code will not exist in main) or drop tactics a note to tell them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.