Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded parentheses in SQL queries #26767

Closed
roji opened this issue Nov 19, 2021 · 1 comment · Fixed by #30371
Closed

Remove unneeded parentheses in SQL queries #26767

roji opened this issue Nov 19, 2021 · 1 comment · Fixed by #30371
Assignees
@maumar @roji
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone
8.0.0

Comments

@roji
Copy link
Member

roji commented Nov 19, 2021 •
edited

#26652 was about where IS NULL was missing parentheses, causing wrong evaluation and incorrect data being returned by queries (x = y IS NULL). This was fixed in a simple way in #26653 for 6.0, but added lots of unneeded parentheses too at the same time.

For 8.0, build upon #23895 to do this better, without adding spurious parentheses.
@roji roji mentioned this issue Nov 19, 2021
Closed
@ajcvickers ajcvickers added this to the 7.0.0 milestone Dec 1, 2021
@roji roji mentioned this issue Jan 11, 2022
Closed
@roji
Copy link
Member Author

roji commented Jan 11, 2022

Note to self: reenable test Bool_not_equal_nullable_int_HasValue when doing this.

roji added a commit to roji/efcore that referenced this issue Jan 12, 2022
@roji
Put parentheses around IS NULL for non-bool operands, where needed only
cc199ad 
Fixes dotnet#26767
This was referenced Jan 13, 2022
Closed
Closed
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 17, 2022
roji added a commit to roji/efcore that referenced this issue Jan 22, 2022
@roji
Put parentheses around IS NULL for non-bool operands, where needed only
efb2180 
Fixes dotnet#26767
@roji roji mentioned this issue Aug 8, 2022
Closed
@roji roji changed the title Place parentheses around IS NULL only when needed (7.0) Remove unneeded parentheses in SQL queries Aug 8, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 8.0.0 Sep 10, 2022
@ajcvickers ajcvickers added priority-bug Issues which requires API breaks and have bigger impact hence should be fixed earlier in the release punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. labels Sep 10, 2022
@roji roji removed priority-bug Issues which requires API breaks and have bigger impact hence should be fixed earlier in the release closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Nov 25, 2022
roji added a commit to roji/efcore that referenced this issue Dec 1, 2022
@roji
Full management of SQL operator precedence/associativity
cdfe708 
Removing unnecessary parentheses

Closes dotnet#26767
@ajcvickers ajcvickers mentioned this issue Dec 6, 2022
Closed
maumar pushed a commit that referenced this issue Jan 12, 2023
@roji @maumar
Full management of SQL operator precedence/associativity
5740ea6 
Removing unnecessary parentheses

Closes #26767
maumar pushed a commit that referenced this issue Mar 1, 2023
@roji @maumar
Full management of SQL operator precedence/associativity
66aa2b9 
Removing unnecessary parentheses

Closes #26767
maumar pushed a commit that referenced this issue Mar 1, 2023
@roji @maumar
Full management of SQL operator precedence/associativity
7e7ff46 
Removing unnecessary parentheses

Closes #26767

rebase, fix sqlite tests and move some ops tests around
maumar pushed a commit that referenced this issue Mar 1, 2023
@roji @maumar
Full management of SQL operator precedence/associativity
993205a 
Removing unnecessary parentheses

Closes #26767
@roji roji mentioned this issue Mar 9, 2023
Merged
maumar added a commit that referenced this issue Mar 9, 2023
@maumar @roji
Full management of SQL operator precedence/associativity (#30371)
564500f 
Removing unnecessary parentheses

Closes #26767

Co-authored-by: Shay Rojansky <roji@roji.org>
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 9, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview3 Mar 13, 2023
@ajcvickers ajcvickers mentioned this issue Apr 13, 2023
Closed
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview3, 8.0.0 Nov 14, 2023
This was referenced Dec 5, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

@roji roji

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Milestone
8.0.0
3 participants
@ajcvickers @maumar @roji