Skip to content

Pass -publish parameters #54620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Pass -publish parameters #54620

merged 4 commits into from
Mar 19, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Mar 19, 2024

https://github.com/dotnet/aspnetcore/pull/54422/files introduced new build script switches for -publish and -no-publish to be compatible with VMR workflows. The aspnetcore CI jobs were passing /p:Publish=true instead of using such a switch. The default value for the new switch if not passed is false, so essentially this turned off publishing for much of aspnetcore. Fix this by not using the msbuild property. Instead, pass the switch. This matches standard arcade repo patterns.

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Sorry, something went wrong.

https://github.com/dotnet/aspnetcore/pull/54422/files introduced new build script switches for -publish and -no-publish to be compatible with VMR workflows. The aspnetcore CI jobs were passing /p:Publish=true instead of using such a switch. The default value for the new switch if not passed is false, so essentially this turned off publishing for much of aspnetcore. Fix this by not using the msbuild property. Instead, pass the switch. This matches standard arcade repo patterns.
@mmitche mmitche requested review from wtgodbe and a team as code owners March 19, 2024 15:34
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 19, 2024
@mmitche
Copy link
Member Author

mmitche commented Mar 19, 2024

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the submodule changes? LGTM after that

mmitche added 2 commits March 19, 2024 12:16
@mmitche mmitche enabled auto-merge (squash) March 19, 2024 21:19
@RussKie
Copy link
Member

RussKie commented Mar 19, 2024

This is expected to unblock the flow into dotnet/extensions#5047

@RussKie
Copy link
Member

RussKie commented Mar 19, 2024

Thank you

@wtgodbe
Copy link
Member

wtgodbe commented Mar 19, 2024

Failures unrelated - getting this in before the p3 snap

@wtgodbe wtgodbe disabled auto-merge March 19, 2024 23:59
@wtgodbe wtgodbe merged commit e62490d into dotnet:main Mar 19, 2024
21 of 26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants