-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Pass -publish parameters #54620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pass -publish parameters #54620
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/dotnet/aspnetcore/pull/54422/files introduced new build script switches for -publish and -no-publish to be compatible with VMR workflows. The aspnetcore CI jobs were passing /p:Publish=true instead of using such a switch. The default value for the new switch if not passed is false, so essentially this turned off publishing for much of aspnetcore. Fix this by not using the msbuild property. Instead, pass the switch. This matches standard arcade repo patterns.
ViktorHofer
approved these changes
Mar 19, 2024
wtgodbe
reviewed
Mar 19, 2024
3 tasks
wtgodbe
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the submodule changes? LGTM after that
ViktorHofer
approved these changes
Mar 19, 2024
This is expected to unblock the flow into dotnet/extensions#5047 |
Thank you |
Failures unrelated - getting this in before the p3 snap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/aspnetcore/pull/54422/files introduced new build script switches for -publish and -no-publish to be compatible with VMR workflows. The aspnetcore CI jobs were passing /p:Publish=true instead of using such a switch. The default value for the new switch if not passed is false, so essentially this turned off publishing for much of aspnetcore. Fix this by not using the msbuild property. Instead, pass the switch. This matches standard arcade repo patterns.
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)