Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Identity transitive dependency resulting in security check failures due to CVE-2023-36414 #2198

Closed
StasJS opened this issue Oct 26, 2023 · 5 comments
Labels
Duplicate This issue or pull request already exists

Comments

@StasJS
Copy link

StasJS commented Oct 26, 2023

Hi there,

My organisation performs security checks on application dependencies, including transitive dependencies.

We directly depend on Microsoft.Data.SqlClient (currently version 5.1.1). I see that this package in turn depends on Azure.Identity (>= 1.7.0).

Our applications don't depend on directly Azure.Identity directly, or leverage Azure capabilities within Microsoft.Data.SqlClient in any way. This means we are pulling in Azure.Identity v1.7.0 implicitly.

On 2023/10/13, CVE-2023-36414 was published, affecting versions of Azure.Identity up to v1.10.2. This CVE has been causing our security checks for applications to fail.

Looking at the latest (prerelease) version, the minimum version for Azure.Identity is only1.8.0. Thus upgrading to the latest pre-release version of Microsoft.Data.SqlClient would not resolve the security check violation for CVE-2023-36414.

We are currently silencing this violation as it's coming from what appears to be an optional dependency for Microsoft.Data.SqlClient that we aren't leveraging via our usage of Microsoft.Data.SqlClient. This is on the assumption that CVE is not an actually an issue in this scenario - if you are aware of that being a faulty assumption do let me know.

The only other alternative we see would be to take an artificial direct dependency on Azure.Identity so we can specify a version >= 1.10.2, where the CVE is fixed. However we support a number of applications experiencing this issue and would prefer not to incur this kind of technical debt.

Ideally we'd like to see a new version of this library published which updates the minimum version of Azure.Identity to one where the CVE-2023-36414 is fixed.

Keen to hear your thoughts on this issue! Let me know if you need more information.

@StasJS StasJS changed the title Azure.Identity transitive dependency resulting in security check failures Azure.Identity transitive dependency resulting in security check failures due to CVE Oct 26, 2023
@StasJS StasJS changed the title Azure.Identity transitive dependency resulting in security check failures due to CVE Azure.Identity transitive dependency resulting in security check failures due to CVE-2023-36414 Oct 26, 2023
@JRahnama JRahnama added the Duplicate This issue or pull request already exists label Oct 26, 2023
@JRahnama
Copy link
Member

Fixes are merged in the PR #2188
Closing as a duplicate for #2181 and #2190

@StasJS
Copy link
Author

StasJS commented Oct 26, 2023

As discussed in #2189, this change will be shipped in 5.2.0-preview4

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 26, 2023

@javad is this fix in 5.1.2? And why not?

@David-Engel
Copy link
Contributor

David-Engel commented Oct 26, 2023

is this fix in 5.1.2? And why not?

No. We didn't find out about it in time to include it in 5.1.2. Additionally, users have to be able to control the tenant ID and/or scope to be vulnerable to the issue and that isn't user-controlled input from MDS. We do plan to include it in a future hotfix version.

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 26, 2023

@David-Engel Thanks for that explanation. So neither SqlClient or EF Core are vulnerable in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants