Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change | Revert excluding unsupported protocols #1824

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

DavoudEshtehari
Copy link
Member

Regarding issue #1151 and related PR #1168, the proposed changes are not required anymore since Windows 10 and/or SQL Server 2019 have fixed the issue while Microsoft.Data.SqlClient has been adding support for TLS 1.3.

  • Note: Native SNI changes are proposed in the internal Pull Request 3527: Revert PR 2947 Remove UseSystemDefaultSecureProtocols

@DavoudEshtehari DavoudEshtehari added this to the 5.1.0-preview2 milestone Nov 2, 2022
@DavoudEshtehari DavoudEshtehari added this to In Progress in SqlClient v5.1 via automation Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 71.41% // Head: 71.31% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (fa4d9bd) compared to base (146c34e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
- Coverage   71.41%   71.31%   -0.10%     
==========================================
  Files         290      290              
  Lines       61280    61271       -9     
==========================================
- Hits        43761    43697      -64     
- Misses      17519    17574      +55     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.85% <100.00%> (-0.16%) ⬇️
netfx 69.31% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icrosoft/Data/SqlClient/LocalAppContextSwitches.cs 56.25% <ø> (-8.75%) ⬇️
...core/src/Interop/SNINativeMethodWrapper.Windows.cs 98.83% <100.00%> (ø)
...core/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs 21.42% <100.00%> (-20.68%) ⬇️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 80.51% <100.00%> (ø)
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 62.69% <0.00%> (-0.80%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.28% <0.00%> (-0.37%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lcheunglci lcheunglci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just verified it with my changes and it works! Thanks!

SqlClient v5.1 automation moved this from In Progress to Review Approved Nov 3, 2022
@JRahnama
Copy link
Member

JRahnama commented Nov 3, 2022

/AzurePipelines Run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JRahnama JRahnama changed the title Revert excluding unsupported protocols Change | Revert excluding unsupported protocols Nov 3, 2022
@JRahnama JRahnama merged commit f684185 into dotnet:main Nov 3, 2022
SqlClient v5.1 automation moved this from Review Approved to Done Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants