Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing SaveAs #1376

Closed
twsouthwick opened this issue Mar 30, 2023 · 1 comment
Closed

Consider removing SaveAs #1376

twsouthwick opened this issue Mar 30, 2023 · 1 comment
Assignees
@tomjebo
Labels
breaking-change
Milestone
v3.0.0-beta1

Comments

@twsouthwick
Copy link
Member

This API does nothing but forward to Clone() and has unintuitive behavior (i.e. it saves the current package and returns a new package). I'd rather remove it for now and add it back when we have something that makes more sense.
@twsouthwick twsouthwick added this to the v3.0 milestone Mar 30, 2023
@tomjebo tomjebo self-assigned this Apr 4, 2023
@twsouthwick twsouthwick mentioned this issue Apr 5, 2023
Closed
@twsouthwick twsouthwick modified the milestones: v3.0, v3.0.0-beta1 Apr 7, 2023
@twsouthwick
Copy link
Member Author

@tomjebo didn't you finish this?

@tomjebo tomjebo mentioned this issue Apr 18, 2023
Merged
@tomjebo tomjebo closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomjebo tomjebo

Labels
breaking-change
Projects
None yet
Milestone
v3.0.0-beta1
Development

No branches or pull requests
2 participants
@twsouthwick @tomjebo