Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 3.5.119 to 3.6.132 breaks commit id for NPM #943

Closed
woppa684 opened this issue May 16, 2023 · 4 comments · Fixed by #945
Closed

Upgrading from 3.5.119 to 3.6.132 breaks commit id for NPM #943

woppa684 opened this issue May 16, 2023 · 4 comments · Fixed by #945
Labels
Milestone

Comments

@woppa684
Copy link

woppa684 commented May 16, 2023

version.json

{
  "$schema":  "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
  "version":  "7.1.0-next.{height}",
  "publicReleaseRefSpec":  [
    "^refs/heads/releases/v\\d+\\.\\d+$"
  ]
}

Output of get-version for 3.5.119

Version:                      7.1.0
AssemblyVersion:              7.1.0.0
AssemblyInformationalVersion: 7.1.0-next.16+38d39d2671
NuGetPackageVersion:          7.1.0-next.16.g38d39d2671
NpmPackageVersion:            7.1.0-next.16.g38d39d2671

Output of get-version for 3.6.132

Version:                      7.1.0
AssemblyVersion:              7.1.0.0
AssemblyInformationalVersion: 7.1.0-next.16+38d39d2671
NuGetPackageVersion:          7.1.0-next.16.g38d39d2671
NpmPackageVersion:            7.1.0-next.16

Is this related to this commit? 5e1adb5

So, we use this to make distinct prereleases, should we switch to using the NuGetPackageVersion instead?

@AArnott
Copy link
Collaborator

AArnott commented May 17, 2023

I was wondering myself today if perhaps I had been mistaken in the belief behind that commit that NPM doesn't support the .commitID syntax in the version. It sounds like you agree that was a mistake. I wonder what led me to believe it was being dropped. I'll bring it back.

@AArnott AArnott added the bug label May 17, 2023
@AArnott AArnott added this to the v3.6 milestone May 17, 2023
AArnott added a commit that referenced this issue May 17, 2023
@AArnott AArnott linked a pull request May 17, 2023 that will close this issue
@woppa684
Copy link
Author

woppa684 commented May 17, 2023

Thanks for the quick repsonse! As far as I know, NPM just follows the semver spec, and any dot-separated prerelease identifiers after a hyphen are ok Now we'll just wait for a release :)

@AArnott AArnott closed this as completed May 17, 2023
@woppa684
Copy link
Author

@AArnott Any idea when a new release will be made? We have more and more repositories that need to revert now ...

@AArnott
Copy link
Collaborator

AArnott commented May 23, 2023

3.6.133 going out to nuget right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants