Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerdbank.GitVersioning used with WixToolset Bundle projects #913

Closed
maniglia opened this issue Mar 30, 2023 · 3 comments · Fixed by #918
Closed

Nerdbank.GitVersioning used with WixToolset Bundle projects #913

maniglia opened this issue Mar 30, 2023 · 3 comments · Fixed by #918

Comments

@maniglia
Copy link
Contributor

I have the following error message when i want to use Nerdbank.GitVersioning on WixToolset Bundle (output .exe) project:
CodeDomProvider not available for language: wix. No version info will be embedded into assembly.

The property <NBGV_EmitThisAssemblyClass>false</NBGV_EmitThisAssemblyClass> it doesn't solve the problem.

Do you think this can be handled in AssemblyVersionInfo.cs?

@maniglia
Copy link
Contributor Author

As a workaround using this <GenerateAssemblyVersionInfo>false</GenerateAssemblyVersionInfo> it's possible to use Nerdbank.GitVersioning in Wix Bundle projects.

What do you think about the following solution?

I would add the following lines in Nerdbank.GitVersioning.targets files to the line: 42
<!-- Suppress assembly version info generation for WixToolset Bundle project. -->
<GenerateAssemblyVersionInfo Condition=" '$(GenerateAssemblyVersionInfo)' == '' and '$(Language)' == 'wix' and '$(TargetExt)' == '.exe' ">false</GenerateAssemblyVersionInfo>

@AArnott
Copy link
Collaborator

AArnott commented Apr 6, 2023

Your workaround and proposed code change looks good to me. What if you drop the $(TargetExt) part of the condition though, since that seems irrelevant. Wanna send a PR?

@maniglia
Copy link
Contributor Author

maniglia commented Apr 7, 2023

This is the PR #918.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants