ThisAssembly from Nerbank.GitVersioning conflicts with ThisAssembly from "ThisAssembly"

[nathanwinder]

Issue Report to "ThisAssembly"

devlooped/ThisAssembly#124

Describe the Bug

ThisAssembly conflicts with the "ThisAssembly" generated by Nerdbank.GitVersioning
https://github.com/dotnet/Nerdbank.GitVersioning

Steps to Reproduce

1. Reference both Nerdbank.GitVersioning and ThisAssembly.Project

<PackageReference Include="ThisAssembly.Project" Version="1.0.9" Condition="!Exists('packages.config')"/>
<PackageReference Include="Nerdbank.GitVersioning" Condition="!Exists('packages.config')">
  <PrivateAssets>all</PrivateAssets>
  <Version>3.5.113</Version>
</PackageReference>

public class ReproTest
{
  [Fact]
  public void Repro()
  {
    var fileVersion = ThisAssembly.AssemblyFileVersion; // 'ThisAssembly' does not contain a definition for 'AssemblyName'
  }
}

Expected Behavior

ThisAssembly.Project should not prevent Nerbbank.GitVersioning from creating ThisAssembly properties.

[nathanwinder]

Did some more research into this and it has something to do with "Directory.Build.props". I have them in nested directories and GitVersioning stopped working. I removed the props in the descendant directory but GitVersioning has stopped working.

-Folder
--Directory.Build.props

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemGroup>
    <PackageReference Include="Nerdbank.GitVersioning" Condition="!Exists('packages.config')">
      <PrivateAssets>all</PrivateAssets>
      <Version>3.5.113</Version>
    </PackageReference>
  </ItemGroup>
</Project>

-- SubFolder
---Directory.Build.props

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemGroup>
   <PackageReference Include="ThisAssembly.Project" Version="1.0.9" Condition="!Exists('packages.config')"/>
  </ItemGroup>
</Project>

---My.sln

GitVersioning stopped working, the package reference was no longer propagating even if I removed the props in the descendant folder. Both will work together if directly referenced from the project.

[AArnott]

Nerdbank.GitVersioning generates ThisAssembly the same regardless of how/where you reference nb.gv.
To get along with another ThisAssembly generator, what would it take? Can you include details of the conflict? I see we already use the partial modifier or the class declaration, so I don't know what else we could do. If the properties themselves conflict, maybe you're using two packages that are too similar to be combined in one project.

[alexrp]

I suppose this can be closed as of #911?