Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packing of BenchmarkDotNet.TestAdapter is broken #2492

Closed
AndreyAkinshin opened this issue Jan 5, 2024 · 0 comments
Closed

Packing of BenchmarkDotNet.TestAdapter is broken #2492

AndreyAkinshin opened this issue Jan 5, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@AndreyAkinshin
Copy link
Member

If we try to pack BenchmarkDotNet.TestAdapter, we will get the following error:

/Users/akinshin/Work/BenchmarkDotNet/.dotnet/sdk/8.0.100/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5129: Warning As Error: - At least one .props file was found in 'build/', but 'build/BenchmarkDotNet.TestAdapter.props' was not. [/Users/akinshin/Work/BenchmarkDotNet/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj]
/Users/akinshin/Work/BenchmarkDotNet/.dotnet/sdk/8.0.100/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5129:  [/Users/akinshin/Work/BenchmarkDotNet/src/BenchmarkDotNet.TestAdapter/BenchmarkDotNet.TestAdapter.csproj]

It seems that it's caused by NuGet/Home#9055 Moving BenchmarkDotNet.TestAdapter.props from Package\ to build\ fixes the issue.


A related problem is about our CI testing workflows. The BenchmarkDotNet.TestAdapter was introduced in #2438, but we failed to discover the problem it during the review process. Our automatic CI tests check the status of unit and integration tests, but they do not test that the solution can be packed. Meanwhile, merging non-packable projects to the master branch leads to a broken publish-nightly workflow.

We should introduce an additional workflow that checks the packability of the solution for the given PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant