Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in parsing arguments with spaces #2373

Closed
radical opened this issue Jul 18, 2023 · 3 comments · Fixed by #2375
Closed

Regression in parsing arguments with spaces #2373

radical opened this issue Jul 18, 2023 · 3 comments · Fixed by #2375
Assignees
@kant2002
Labels
Area:CommandLine
Milestone
v0.13.7

Comments

@radical
Copy link
Member

radical commented Jul 18, 2023

Passing arguments to bdn as "--wasmArgs=--expose_wasm --module" has regressed. What works now is --wasmArgs "--expose_wasm --module".

cc @LoopedBard3 @adamsitnik @lewing

related: dotnet/runtime#89091
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Jul 18, 2023 •
edited

I am seeing something like this too...

c:\repos\performance\src\benchmarks\micro>dotnet run -c Release -f net8.0 -- --filter "System.Tests.Perf_UInt32.TryParseHex(value: \"0\")" --corerun C:\bugs\r87194\base\corerun.exe C:\bugs\r87194\diff\corerun.exe
You must have made a typo in ' System.Tests.Perf_UInt32.TryParseHex(value: "0")'. Suggestions:
        System.Tests.Perf_UInt32.TryParseHex(value: "0")
        System.Tests.Perf_UInt64.TryParseHex(value: "0")
To print all available benchmarks use `--list flat` or `--list tree`.
To learn more about filtering use `--help`.

This was from BenchmarkDotNet v0.13.7-nightly.20230717.35 which is what's currently spec'd by https://dotnet/performance

@timcassell
Copy link
Collaborator

@kant2002 Looks like this was introduced in #2320.

kant2002 added a commit to kant2002/BenchmarkDotNet that referenced this issue Jul 19, 2023
@kant2002
Fix regression in parsing arguments with spaces
9c828c3 
Closes dotnet#2373
@kant2002 kant2002 mentioned this issue Jul 19, 2023
Merged
@kant2002
Copy link
Contributor

I send PR. Apologize for disruption.

timcassell added a commit that referenced this issue Jul 19, 2023
@kant2002 @timcassell
Fix regression in parsing arguments with spaces Closes #2373 (#2375)
dc9b804 
* Fix regression in parsing arguments with spaces
Closes #2373

* Add test for filtering by parameters

* Update tests/BenchmarkDotNet.Tests/TypeFilterTests.cs

Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>

---------

Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>
@timcassell timcassell added this to the v0.13.7 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kant2002 kant2002

Labels
Area:CommandLine
Projects
None yet
Milestone
v0.13.7
Development

Successfully merging a pull request may close this issue.

Fix regression in parsing arguments with spaces Closes #2373 kant2002/BenchmarkDotNet
4 participants
@radical @kant2002 @AndyAyersMS @timcassell