feat(typescript-resolvers): use import type when importing from graphql
#4437
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great :) We are close to make it compatible with all plugins ;) Thanks @SimenB ! |
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
mjbcopland
pushed a commit
to mjbcopland/graphql-code-generator
that referenced
this pull request
Jul 30, 2020
…mha#4355) Fixing angular tests to await all typescript validation calls Fixing angular test to use correct mutation/subscription gql calls. Co-authored-by: asaf <asaf@truenorthsys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one for #3695. For my own use case I believe I'm just missing
react-apollo. However, I'm not sure when it's safe to doimport typeand when not to there - help would be appreciated 🙂 This is however enough for the stuff we have server side 🎉