Fix bug with flow-operations codegeneration and flattenGeneratedTypes config #4287
+546
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
This looks great, thank you @ganemone ! Just one comment related to the flow comment
ardatan
reviewed
Jun 27, 2020
|
Hey In the generated file, you can find: /* @flow */
// @flowWhen we have smth like this we got error: |
|
Is this a flow lint error? AFAIK there is no problem with having multiple flow comments in a single flow file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where fragment types are not generated when
flattenGeneratedTypesconfig is provided for flow operations.