JSDoc: Removed incorrect results for documents containing operations #4239
+73
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @CarloPalinckx ! |
|
@CarloPalinckx can you please check the CI? it seems to fail :( |
|
@dotansimha should be fine now 🙂 |
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin does not yet support operations as output, however when your documents contain operations it breaks the output by casting an object to string. Resulting in a
[object Object]in the output. Which could turn out to be trouble when ran with a bundler. This PR removes that behaviour and makes it so that the plugin no-op's when encountering a operation or fragment.